netdev - Re: [PATCH AUTOSEL 6.2 26/53] netpoll: Remove 4s sleep during carrier detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y/60ExOLZSb4oWP/@sashalap>
Date:   Tue, 28 Feb 2023 21:10:27 -0500
From:   Sasha Levin <sashal@...nel.org>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Breno Leitao <leitao@...ian.org>,
        Michael van der Westhuizen <rmikey@...a.com>,
        davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
        wsa+renesas@...g-engineering.com, netdev@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 6.2 26/53] netpoll: Remove 4s sleep during
 carrier detection

On Mon, Feb 27, 2023 at 10:15:32AM -0800, Jakub Kicinski wrote:
>On Sun, 26 Feb 2023 09:44:18 -0500 Sasha Levin wrote:
>> From: Breno Leitao <leitao@...ian.org>
>>
>> [ Upstream commit d8afe2f8a92d2aac3df645772f6ee61b0b2fc147 ]
>>
>> This patch removes the msleep(4s) during netpoll_setup() if the carrier
>> appears instantly.
>>
>> Here are some scenarios where this workaround is counter-productive in
>> modern ages:
>
>Potential behavior change, can we wait 4 weeks, until it's been
>in a couple of -rcs?

Dropped for now, will revisit in a few weeks. Thanks!

-- 
Thanks,
Sasha