netdev - Re: [PATCH AUTOSEL 6.2 31/53] neighbor: fix proxy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y/9dizGq97wpbZpn@sashalap>
Date:   Wed, 1 Mar 2023 09:13:31 -0500
From:   Sasha Levin <sashal@...nel.org>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Brian Haley <haleyb.dev@...il.com>, davem@...emloft.net,
        edumazet@...gle.com, pabeni@...hat.com, corbet@....net,
        den@...nvz.org, razor@...ckwall.org, ulf.hansson@...aro.org,
        Jason@...c4.com, wangyuweihx@...il.com, daniel@...earbox.net,
        thomas.zeitlhofer+lkml@...it.at, alexander@...alicyn.com,
        ja@....bg, netdev@...r.kernel.org, linux-doc@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 6.2 31/53] neighbor: fix proxy_delay usage when
 it is zero

On Mon, Feb 27, 2023 at 10:15:04AM -0800, Jakub Kicinski wrote:
>On Sun, 26 Feb 2023 09:44:23 -0500 Sasha Levin wrote:
>> From: Brian Haley <haleyb.dev@...il.com>
>>
>> [ Upstream commit 62e395f82d04510b0f86e5e603e29412be88596f ]
>>
>> When set to zero, the neighbor sysctl proxy_delay value
>> does not cause an immediate reply for ARP/ND requests
>> as expected, it instead causes a random delay between
>> [0, U32_MAX). Looking at this comment from
>> __get_random_u32_below() explains the reason:
>
>Potential behavior change, can we wait 4 weeks, until it's been
>in a couple of -rcs?

Ack, will revisit this later. Thanks!

-- 
Thanks,
Sasha