netdev - Re: [PATCH net v3] ice: copy last block omitted in ice_get_module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2d221713-cafa-8460-df6b-ccd11f42e4cb@intel.com>
Date:   Fri, 3 Mar 2023 12:12:40 +0100
From:   Alexander Lobakin <aleksander.lobakin@...el.com>
To:     Petr Oros <poros@...hat.com>
CC:     <netdev@...r.kernel.org>, <jesse.brandeburg@...el.com>,
        <anthony.l.nguyen@...el.com>, <davem@...emloft.net>,
        <edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
        <scott.w.taylor@...el.com>, <intel-wired-lan@...ts.osuosl.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net v3] ice: copy last block omitted in
 ice_get_module_eeprom()

From: Petr Oros <poros@...hat.com>
Date: Wed,  1 Mar 2023 21:47:07 +0100

> ice_get_module_eeprom() is broken since commit e9c9692c8a81 ("ice:
> Reimplement module reads used by ethtool") In this refactor,
> ice_get_module_eeprom() reads the eeprom in blocks of size 8.
> But the condition that should protect the buffer overflow
> ignores the last block. The last block always contains zeros.

[...]

> Fixes: e9c9692c8a81 ("ice: Reimplement module reads used by ethtool")
> Signed-off-by: Petr Oros <poros@...hat.com>

Reviewed-by: Alexander Lobakin <aleksander.lobakin@...el.com>

> ---
> v2: memcpy unified calls
> v3: copy_len is now declared in if scope
>     unwrapped line before memcpy
[...]

Thanks,
Olek