[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202303091536.tx7dCAzn-lkp@intel.com>
Date: Thu, 9 Mar 2023 15:15:45 +0800
From: kernel test robot <lkp@...el.com>
To: Anjali Kulkarni <anjali.k.kulkarni@...cle.com>, davem@...emloft.net
Cc: oe-kbuild-all@...ts.linux.dev, edumazet@...gle.com,
kuba@...nel.org, pabeni@...hat.com, zbr@...emap.net,
brauner@...nel.org, johannes@...solutions.net,
ecree.xilinx@...il.com, leon@...nel.org, keescook@...omium.org,
socketcan@...tkopp.net, petrm@...dia.com,
linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
anjali.k.kulkarni@...cle.com
Subject: Re: [PATCH 2/5] connector/cn_proc: Add filtering to fix some bugs
Hi Anjali,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
[also build test WARNING on net/master vfs-idmapping/for-next linus/master v6.3-rc1 next-20230309]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Anjali-Kulkarni/netlink-Reverse-the-patch-which-removed-filtering/20230309-112151
patch link: https://lore.kernel.org/r/20230309031953.2350213-3-anjali.k.kulkarni%40oracle.com
patch subject: [PATCH 2/5] connector/cn_proc: Add filtering to fix some bugs
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230309/202303091536.tx7dCAzn-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/b27e8d125480d07c95a71e8ef2f0b38d890138cd
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Anjali-Kulkarni/netlink-Reverse-the-patch-which-removed-filtering/20230309-112151
git checkout b27e8d125480d07c95a71e8ef2f0b38d890138cd
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303091536.tx7dCAzn-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/connector/cn_proc.c:51:5: warning: no previous prototype for 'cn_filter' [-Wmissing-prototypes]
51 | int cn_filter(struct sock *dsk, struct sk_buff *skb, void *data)
| ^~~~~~~~~
vim +/cn_filter +51 drivers/connector/cn_proc.c
50
> 51 int cn_filter(struct sock *dsk, struct sk_buff *skb, void *data)
52 {
53 enum proc_cn_mcast_op mc_op;
54
55 if (!dsk)
56 return 0;
57
58 mc_op = ((struct proc_input *)(dsk->sk_user_data))->mcast_op;
59
60 if (mc_op == PROC_CN_MCAST_IGNORE)
61 return 1;
62
63 return 0;
64 }
65 EXPORT_SYMBOL_GPL(cn_filter);
66
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
Powered by blists - more mailing lists