netdev - Re: [PATCH] net: hsr: Don't log netdev_err message on unknown prp dst node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 8 Mar 2023 23:20:01 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Kristian Overskeid <koverskeid@...il.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] net: hsr: Don't log netdev_err message on unknown prp
 dst node

On Tue,  7 Mar 2023 14:32:29 +0100 Kristian Overskeid wrote:
>  	if (!node_dst) {
> -		if (net_ratelimit())
> +		if (net_ratelimit() && port->hsr->prot_version != PRP_V1)

nit: wouldn't the condition make more sense before the net_ratelimit() ?
net_ratelimit() will update its state which is unnecessary if we're not
going to print either way.

When you repost - could you cast a wider net with the CC list?
Add the author of the code? (The print itself, not Taehee)
Maybe some folks who touched this file most recently?

>  			netdev_err(skb->dev, "%s: Unknown node\n", __func__);