netdev - Re: [PATCH net-next] bnx2: remove deadcode in bnx2_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9b367837-4bf0-1802-e753-6eca37e105b9@gmail.com>
Date:   Fri, 10 Mar 2023 10:33:46 +0300
From:   Maxim Korotkov <korotkov.maxim.s@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Rasesh Mody <rmody@...vell.com>, GR-Linux-NIC-Dev@...vell.com,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Michael Chan <mchan@...adcom.com>,
        Vadim Fedorenko <vadim.fedorenko@...ux.dev>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        lvc-project@...uxtesting.org
Subject: Re: [PATCH net-next] bnx2: remove deadcode in bnx2_init_cpus()

On 10.03.2023 09:57, Jakub Kicinski wrote:
> On Thu,  9 Mar 2023 20:42:31 +0300 Maxim Korotkov wrote:
>> The load_cpu_fw function has no error return code
>> and always returns zero. Checking the value returned by
>> this function does not make sense.
>> As a result, bnx2_init_cpus() will also return only zero
>> Therefore, it will be safe to change the type of functions
>> to void and remove checking
> 
> True, but you need to tell the reader why you're making the change.
> One of the impossible-to-hit error handling paths is missing unwind
> or some such?
  Path with error handling was deleted in 57579f7629a3 ("bnx2: Use 
request_firmware()"). This patch is needed to improving readability.
Now checking the value of the return value is misleading when reading 
the code.
Do I need to add this argument to the patch description?
I also forgot to add mark Reviewed-by: Leon Romanovsky 
<leonro@...dia.com> from the previous iteration