netdev - Re: [PATCH net-next] net: introduce budget_squeeze to help us tune rx behavior

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL+tcoAUGyDS=khx7W8V79wck2HAFa2JFsY4-182ASy5m9w+Pw@mail.gmail.com>
Date:   Sun, 12 Mar 2023 08:04:23 +0800
From:   Jason Xing <kerneljasonxing@...il.com>
To:     stephen@...workplumber.org
Cc:     davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, ast@...nel.org, daniel@...earbox.net,
        hawk@...nel.org, john.fastabend@...il.com, kuniyu@...zon.com,
        liuhangbin@...il.com, xiangxia.m.yue@...il.com, jiri@...dia.com,
        bpf@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Jason Xing <kernelxing@...cent.com>
Subject: Re: [PATCH net-next] net: introduce budget_squeeze to help us tune rx behavior

On Sun, Mar 12, 2023 at 1:14 AM Stephen Hemminger
<stephen@...workplumber.org> wrote:
>
> On Sun, 12 Mar 2023 00:36:14 +0800
> Jason Xing <kerneljasonxing@...il.com> wrote:
>
> > -     for (;;) {
> > +     for (; is_continue;) {
>
>
> Easier to read this as a
>         while (is_continue) {
>
> but what is wrong with using break; instead?

If we hit the budget limit and 'break;' immediately, we may miss the
collection when we also hit the time limit. That's why I would like to
know if we hit both of them.

Thank,
Jason