netdev - Re: [PATCH v3 1/5] sunrpc: simplify two-level sysctl registration for tsvcrdma_parm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <724097B6-49DD-437E-9273-5BE40C22C3ED@oracle.com>
Date:   Sun, 12 Mar 2023 01:06:26 +0000
From:   Chuck Lever III <chuck.lever@...cle.com>
To:     Luis Chamberlain <mcgrof@...nel.org>
CC:     Jeff Layton <jlayton@...nel.org>,
        Trond Myklebust <trond.myklebust@...merspace.com>,
        Anna Schumaker <anna@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Linux NFS Mailing List <linux-nfs@...r.kernel.org>,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        coverity-bot <keescook@...omium.org>,
        "yzaikin@...gle.com" <yzaikin@...gle.com>,
        "j.granados@...sung.com" <j.granados@...sung.com>,
        "patches@...ts.linux.dev" <patches@...ts.linux.dev>,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>,
        "open list:NETWORKING [GENERAL]" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 1/5] sunrpc: simplify two-level sysctl registration for
 tsvcrdma_parm_table



> On Mar 11, 2023, at 6:39 PM, Luis Chamberlain <mcgrof@...nel.org> wrote:
> 
> There is no need to declare two tables to just create directories,
> this can be easily be done with a prefix path with register_sysctl().
> 
> Simplify this registration.
> 
> Signed-off-by: Luis Chamberlain <mcgrof@...nel.org>

I can take this one, but I'm wondering what "tsvcrdma_parm_table"
is (see the short description).


> ---
> net/sunrpc/xprtrdma/svc_rdma.c | 21 ++-------------------
> 1 file changed, 2 insertions(+), 19 deletions(-)
> 
> diff --git a/net/sunrpc/xprtrdma/svc_rdma.c b/net/sunrpc/xprtrdma/svc_rdma.c
> index 5bc20e9d09cd..f0d5eeed4c88 100644
> --- a/net/sunrpc/xprtrdma/svc_rdma.c
> +++ b/net/sunrpc/xprtrdma/svc_rdma.c
> @@ -212,24 +212,6 @@ static struct ctl_table svcrdma_parm_table[] = {
> 	{ },
> };
> 
> -static struct ctl_table svcrdma_table[] = {
> -	{
> -		.procname	= "svc_rdma",
> -		.mode		= 0555,
> -		.child		= svcrdma_parm_table
> -	},
> -	{ },
> -};
> -
> -static struct ctl_table svcrdma_root_table[] = {
> -	{
> -		.procname	= "sunrpc",
> -		.mode		= 0555,
> -		.child		= svcrdma_table
> -	},
> -	{ },
> -};
> -
> static void svc_rdma_proc_cleanup(void)
> {
> 	if (!svcrdma_table_header)
> @@ -263,7 +245,8 @@ static int svc_rdma_proc_init(void)
> 	if (rc)
> 		goto out_err;
> 
> -	svcrdma_table_header = register_sysctl_table(svcrdma_root_table);
> +	svcrdma_table_header = register_sysctl("sunrpc/svc_rdma",
> +					       svcrdma_parm_table);
> 	return 0;
> 
> out_err:
> -- 
> 2.39.1
> 

--
Chuck Lever