netdev - Re: [PATCH net-next 1/2] neighbour: annotate lockless accesses to n->nud

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c465f247-5305-9aa7-06f1-8958ff6f1990@kernel.org>
Date:   Mon, 13 Mar 2023 14:45:45 -0600
From:   David Ahern <dsahern@...nel.org>
To:     Eric Dumazet <edumazet@...gle.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net-next 1/2] neighbour: annotate lockless accesses to
 n->nud_state

On 3/13/23 2:17 PM, Eric Dumazet wrote:
> We have many lockless accesses to n->nud_state.
> 
> Before adding another one in the following patch,
> add annotations to readers and writers.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> ---
>  drivers/net/vxlan/vxlan_core.c  |  4 ++--
>  include/net/neighbour.h         |  2 +-
>  net/bridge/br_arp_nd_proxy.c    |  4 ++--
>  net/bridge/br_netfilter_hooks.c |  3 ++-
>  net/core/filter.c               |  4 ++--
>  net/core/neighbour.c            | 28 ++++++++++++++--------------
>  net/ipv4/arp.c                  |  8 ++++----
>  net/ipv4/fib_semantics.c        |  4 ++--
>  net/ipv4/nexthop.c              |  4 ++--
>  net/ipv4/route.c                |  2 +-
>  net/ipv6/ip6_output.c           |  2 +-
>  net/ipv6/ndisc.c                |  4 ++--
>  net/ipv6/route.c                |  2 +-
>  13 files changed, 36 insertions(+), 35 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>