netdev - Re: [PATCH net-next 2/2] ipv6: remove one read_lock()/read_unlock() pair in rt6_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0121dad1-8ae4-9b05-7d26-1afba472340f@kernel.org>
Date:   Mon, 13 Mar 2023 14:46:53 -0600
From:   David Ahern <dsahern@...nel.org>
To:     Eric Dumazet <edumazet@...gle.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net-next 2/2] ipv6: remove one read_lock()/read_unlock()
 pair in rt6_check_neigh()

On 3/13/23 2:17 PM, Eric Dumazet wrote:
> rt6_check_neigh() uses read_lock() to protect n->nud_state reading.
> 
> This seems overkill and causes false sharing.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> ---
>  net/ipv6/route.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>