netdev - Re: [RFC net-next 1/3] net: provide macros for commonly copied lockless queue stop/wake code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230313135640.3a511db0@kernel.org>
Date:   Mon, 13 Mar 2023 13:56:40 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     Willem de Bruijn <willemdebruijn.kernel@...il.com>,
        netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
        pabeni@...hat.com, alexanderduyck@...com, roman.gushchin@...ux.dev
Subject: Re: [RFC net-next 1/3] net: provide macros for commonly copied
 lockless queue stop/wake code

On Sun, 12 Mar 2023 18:45:15 -0700 Stephen Hemminger wrote:
> > > Could any of these be inline functions instead for type safety?    
> > 
> > I suppose not because of the condition that is evaluated.  
> 
> It is more that the condition needs to evaluated after some other
> pre-conditions.

Right, I think I could slice off individual chunks and wrap them in
static inlines, but I reckon the result is relatively readable now?