netdev - Re: [PATCH net-next 01/11] net: Add MDB net device operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <36d6a40a-8f5a-3152-a694-d15bdb3578b4@blackwall.org>
Date:   Tue, 14 Mar 2023 13:41:53 +0200
From:   Nikolay Aleksandrov <razor@...ckwall.org>
To:     Ido Schimmel <idosch@...dia.com>, netdev@...r.kernel.org,
        bridge@...ts.linux-foundation.org
Cc:     davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
        edumazet@...gle.com, roopa@...dia.com, petrm@...dia.com,
        mlxsw@...dia.com
Subject: Re: [PATCH net-next 01/11] net: Add MDB net device operations

On 13/03/2023 16:53, Ido Schimmel wrote:
> Add MDB net device operations that will be invoked by rtnetlink code in
> response to received RTM_{NEW,DEL,GET}MDB messages. Subsequent patches
> will implement these operations in the bridge and VXLAN drivers.
> 
> Signed-off-by: Ido Schimmel <idosch@...dia.com>
> ---
>  include/linux/netdevice.h | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
> 
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index ee483071cf59..23b0d7eaaadd 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -1307,6 +1307,17 @@ struct netdev_net_notifier {
>   *	Used to add FDB entries to dump requests. Implementers should add
>   *	entries to skb and update idx with the number of entries.
>   *
> + * int (*ndo_mdb_add)(struct net_device *dev, struct nlattr *tb[],
> + *		      u16 nlmsg_flags, struct netlink_ext_ack *extack);
> + *	Adds an MDB entry to dev.
> + * int (*ndo_mdb_del)(struct net_device *dev, struct nlattr *tb[],
> + *		      struct netlink_ext_ack *extack);
> + *	Deletes the MDB entry from dev.
> + * int (*ndo_mdb_dump)(struct net_device *dev, struct sk_buff *skb,
> + *		       struct netlink_callback *cb);
> + *	Dumps MDB entries from dev. The first argument (marker) in the netlink
> + *	callback is used by core rtnetlink code.
> + *
>   * int (*ndo_bridge_setlink)(struct net_device *dev, struct nlmsghdr *nlh,
>   *			     u16 flags, struct netlink_ext_ack *extack)
>   * int (*ndo_bridge_getlink)(struct sk_buff *skb, u32 pid, u32 seq,
> @@ -1569,6 +1580,16 @@ struct net_device_ops {
>  					       const unsigned char *addr,
>  					       u16 vid, u32 portid, u32 seq,
>  					       struct netlink_ext_ack *extack);
> +	int			(*ndo_mdb_add)(struct net_device *dev,
> +					       struct nlattr *tb[],
> +					       u16 nlmsg_flags,
> +					       struct netlink_ext_ack *extack);
> +	int			(*ndo_mdb_del)(struct net_device *dev,
> +					       struct nlattr *tb[],
> +					       struct netlink_ext_ack *extack);
> +	int			(*ndo_mdb_dump)(struct net_device *dev,
> +						struct sk_buff *skb,
> +						struct netlink_callback *cb);
>  	int			(*ndo_bridge_setlink)(struct net_device *dev,
>  						      struct nlmsghdr *nlh,
>  						      u16 flags,

Reviewed-by: Nikolay Aleksandrov <razor@...ckwall.org>