netdev - Re: [PATCH net-next 02/11] bridge: mcast: Implement MDB net device operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d4a39646-ed81-d900-6cd7-a87c561f8049@blackwall.org>
Date:   Tue, 14 Mar 2023 13:43:11 +0200
From:   Nikolay Aleksandrov <razor@...ckwall.org>
To:     Ido Schimmel <idosch@...dia.com>, netdev@...r.kernel.org,
        bridge@...ts.linux-foundation.org
Cc:     davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
        edumazet@...gle.com, roopa@...dia.com, petrm@...dia.com,
        mlxsw@...dia.com
Subject: Re: [PATCH net-next 02/11] bridge: mcast: Implement MDB net device
 operations

On 13/03/2023 16:53, Ido Schimmel wrote:
> Implement the previously added MDB net device operations in the bridge
> driver so that they could be invoked by core rtnetlink code in the next
> patch.
> 
> The operations are identical to the existing br_mdb_{dump,add,del}
> functions. The '_new' suffix will be removed in the next patch. The
> functions are re-implemented in this patch to make the conversion in the
> next patch easier to review.
> 
> Add dummy implementations when 'CONFIG_BRIDGE_IGMP_SNOOPING' is
> disabled, so that an error will be returned to user space when it is
> trying to add or delete an MDB entry. This is consistent with existing
> behavior where the bridge driver does not even register rtnetlink
> handlers for RTM_{NEW,DEL,GET}MDB messages when this Kconfig option is
> disabled.
> 
> Signed-off-by: Ido Schimmel <idosch@...dia.com>
> ---
>  net/bridge/br_device.c  |   3 +
>  net/bridge/br_mdb.c     | 124 ++++++++++++++++++++++++++++++++++++++++
>  net/bridge/br_private.h |  25 ++++++++
>  3 files changed, 152 insertions(+)
> 

Reviewed-by: Nikolay Aleksandrov <razor@...ckwall.org>