netdev - Re: [PATCH net-next 03/11] rtnetlink: bridge: mcast: Move MDB handlers out of bridge driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dc4b2eb0-2478-7e26-4292-b8856494fae2@blackwall.org>
Date:   Tue, 14 Mar 2023 13:51:12 +0200
From:   Nikolay Aleksandrov <razor@...ckwall.org>
To:     Ido Schimmel <idosch@...dia.com>, netdev@...r.kernel.org,
        bridge@...ts.linux-foundation.org
Cc:     davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
        edumazet@...gle.com, roopa@...dia.com, petrm@...dia.com,
        mlxsw@...dia.com
Subject: Re: [PATCH net-next 03/11] rtnetlink: bridge: mcast: Move MDB
 handlers out of bridge driver

On 13/03/2023 16:53, Ido Schimmel wrote:
> Currently, the bridge driver registers handlers for MDB netlink
> messages, making it impossible for other drivers to implement MDB
> support.
> 
> As a preparation for VXLAN MDB support, move the MDB handlers out of the
> bridge driver to the core rtnetlink code. The rtnetlink code will call
> into individual drivers by invoking their previously added MDB net
> device operations.
> 
> Note that while the diffstat is large, the change is mechanical. It
> moves code out of the bridge driver to rtnetlink code. Also note that a
> similar change was made in 2012 with commit 77162022ab26 ("net: add
> generic PF_BRIDGE:RTM_ FDB hooks") that moved FDB handlers out of the
> bridge driver to the core rtnetlink code.
> 
> Signed-off-by: Ido Schimmel <idosch@...dia.com>
> ---
> 
> Notes:
>     v1:
>     * Use NL_ASSERT_DUMP_CTX_FITS().
>     * memset the entire context when moving to the next device.
>     * Reset sequence counters when moving to the next device.
>     * Use NL_SET_ERR_MSG_ATTR() in rtnl_validate_mdb_entry().
> 
>  net/bridge/br_device.c  |   6 +-
>  net/bridge/br_mdb.c     | 301 ++--------------------------------------
>  net/bridge/br_netlink.c |   3 -
>  net/bridge/br_private.h |  35 ++---
>  net/core/rtnetlink.c    | 217 +++++++++++++++++++++++++++++
>  5 files changed, 244 insertions(+), 318 deletions(-)
> 

Reviewed-by: Nikolay Aleksandrov <razor@...ckwall.org>