netdev - Re: [PATCH net v2 1/4] bonding: add bond_ether

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1a8be3f2-4c58-e2f9-24eb-06830824e90c@blackwall.org>
Date:   Wed, 15 Mar 2023 10:21:11 +0200
From:   Nikolay Aleksandrov <razor@...ckwall.org>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, monis@...taire.com, syoshida@...hat.com,
        j.vosburgh@...il.com, andy@...yhouse.net, davem@...emloft.net,
        pabeni@...hat.com, edumazet@...gle.com,
        syzbot+9dfc3f3348729cc82277@...kaller.appspotmail.com
Subject: Re: [PATCH net v2 1/4] bonding: add bond_ether_setup helper

On 15/03/2023 09:55, Jakub Kicinski wrote:
> On Tue, 14 Mar 2023 13:14:23 +0200 Nikolay Aleksandrov wrote:
>> +/* ether_setup() resets bond_dev's flags so we always have to restore
>> + * IFF_MASTER, and only restore IFF_SLAVE if it was set
>> + */
>> +static void bond_ether_setup(struct net_device *bond_dev)
>> +{
>> +	unsigned int slave_flag = bond_dev->flags & IFF_SLAVE;
>> +
>> +	ether_setup(bond_dev);
>> +	bond_dev->flags |= IFF_MASTER | slave_flag;
>> +	bond_dev->priv_flags &= ~IFF_TX_SKB_SHARING;
>> +}
>> +
> 
> We can't split this from patch 2, it's going to generate a warning
> under normal build flags, people may have WERROR set these days..

Oh well, that's unfortunate. I'll leave a note in patch 03 that it depends
on the helper added in the other fix.

Thanks,
 Nik