netdev - Re: [PATCH net-next v4] net/smc: Use percpu ref for wr tx reference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZBGBWafISbzBapnq@TONYMAC-ALIBABA.local>
Date:   Wed, 15 Mar 2023 16:27:05 +0800
From:   Tony Lu <tonylu@...ux.alibaba.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Kai <KaiShen@...ux.alibaba.com>, kgraul@...ux.ibm.com,
        wenjia@...ux.ibm.com, jaka@...ux.ibm.com, davem@...emloft.net,
        netdev@...r.kernel.org, linux-s390@...r.kernel.org,
        linux-rdma@...r.kernel.org
Subject: Re: [PATCH net-next v4] net/smc: Use percpu ref for wr tx reference

On Wed, Mar 15, 2023 at 12:34:40AM -0700, Jakub Kicinski wrote:
> On Mon, 13 Mar 2023 06:04:25 +0000 Kai wrote:
> > Signed-off-by: Kai <KaiShen@...ux.alibaba.com>
> 
> Kai Shen ?
> 
> > 
> 
> You're missing a --- separator here, try to apply this patch with 
> git am :/

There is another commit ce7ca794712f ("net/smc: fix fallback failed
while sendmsg with fastopen") that has been merged that also has this
problem. Maybe we can add some scripts to check this?

> 
> > v1->v2:
> > - Modify patch prefix
> > 
> > v2->v3:
> > - Make wr_reg_refcnt a percpu one as well
> > - Init percpu ref with 0 flag instead of ALLOW_REINIT flag
> > 
> > v3->v4:
> > - Update performance data, this data may differ from previous data
> >   as I ran cases on other machines
> > ---