netdev - Re: [PATCH net-next v4] net/smc: Use percpu ref for wr tx reference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230315134045.2daeffa4@kernel.org>
Date:   Wed, 15 Mar 2023 13:40:45 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Tony Lu <tonylu@...ux.alibaba.com>
Cc:     Kai <KaiShen@...ux.alibaba.com>, kgraul@...ux.ibm.com,
        wenjia@...ux.ibm.com, jaka@...ux.ibm.com, davem@...emloft.net,
        netdev@...r.kernel.org, linux-s390@...r.kernel.org,
        linux-rdma@...r.kernel.org
Subject: Re: [PATCH net-next v4] net/smc: Use percpu ref for wr tx reference

On Wed, 15 Mar 2023 16:27:05 +0800 Tony Lu wrote:
> > You're missing a --- separator here, try to apply this patch with 
> > git am :/  
> 
> There is another commit ce7ca794712f ("net/smc: fix fallback failed
> while sendmsg with fastopen") that has been merged that also has this
> problem. Maybe we can add some scripts to check this?

Good idea, checkpatch is probably the right place to complain?
A check along the lines of "if Sign-off-by: has been seen, no
empty lines are allowed until ---"?
Would you be willing to try to code that up and send it to the
checkpatch maintainer? If they refuse we can create a local
check just for networking in our on scripts.