[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZBGivb7ve9LThAX1@corigine.com>
Date: Wed, 15 Mar 2023 11:49:33 +0100
From: Simon Horman <simon.horman@...igine.com>
To: Pedro Tammela <pctammela@...atatu.com>
Cc: netdev@...r.kernel.org, jhs@...atatu.com, xiyou.wangcong@...il.com,
jiri@...nulli.us, davem@...emloft.net, edumazet@...gle.com,
kuba@...nel.org, pabeni@...hat.com, Hangbin Liu <haliu@...hat.com>
Subject: Re: [PATCH net-next] net/sched: act_api: use the correct TCA_ACT
attributes in dump
On Tue, Mar 14, 2023 at 04:33:21PM -0300, Pedro Tammela wrote:
> 3 places in the act api code are using 'TCA_' definitions where they should be using
> 'TCA_ACT_', which is confusing for the reader, although functionaly wise they are equivalent.
>
> Cc: Hangbin Liu <haliu@...hat.com>
> Reviewed-by: Jamal Hadi Salim <jhs@...atatu.com>
> Signed-off-by: Pedro Tammela <pctammela@...atatu.com>
Hi Pedro,
this looks good, but should the instance of TCA_KIND in tcf_del_walker()
also be updated?
Powered by blists - more mailing lists