netdev - Re: [PATCH net-next] net/sched: act_api: use the correct TCA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5d76595f-6af5-2a5a-e56f-ce81bb29dfaf@mojatatu.com>
Date:   Wed, 15 Mar 2023 22:29:49 -0300
From:   Pedro Tammela <pctammela@...atatu.com>
To:     Simon Horman <simon.horman@...igine.com>
Cc:     netdev@...r.kernel.org, jhs@...atatu.com, xiyou.wangcong@...il.com,
        jiri@...nulli.us, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, Hangbin Liu <haliu@...hat.com>
Subject: Re: [PATCH net-next] net/sched: act_api: use the correct TCA_ACT
 attributes in dump

On 15/03/2023 07:49, Simon Horman wrote:
> On Tue, Mar 14, 2023 at 04:33:21PM -0300, Pedro Tammela wrote:
>> 3 places in the act api code are using 'TCA_' definitions where they should be using
>> 'TCA_ACT_', which is confusing for the reader, although functionaly wise they are equivalent.
>>
>> Cc: Hangbin Liu <haliu@...hat.com>
>> Reviewed-by: Jamal Hadi Salim <jhs@...atatu.com>
>> Signed-off-by: Pedro Tammela <pctammela@...atatu.com>
> 
> Hi Pedro,
> 
> this looks good, but should the instance of TCA_KIND in tcf_del_walker()
> also be updated?

Correct, I will add it in v2.