netdev - Re: [net 04/14] net/mlx5: Disable eswitch before waiting for VF pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZBG/Oi7Bda3Rg+gB@nimitz>
Date:   Wed, 15 Mar 2023 13:51:06 +0100
From:   Piotr Raczynski <piotr.raczynski@...el.com>
To:     Saeed Mahameed <saeed@...nel.org>
CC:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        "Saeed Mahameed" <saeedm@...dia.com>, <netdev@...r.kernel.org>,
        Tariq Toukan <tariqt@...dia.com>,
        Daniel Jurgens <danielj@...dia.com>
Subject: Re: [net 04/14] net/mlx5: Disable eswitch before waiting for VF pages

On Tue, Mar 14, 2023 at 10:49:30AM -0700, Saeed Mahameed wrote:
> From: Daniel Jurgens <danielj@...dia.com>
> 
> The offending commit changed the ordering of moving to legacy mode and
> waiting for the VF pages. Moving to legacy mode is important in
> bluefield, because it sends the host driver into error state, and frees
> its pages. Without this transition we end up waiting 2 minutes for
> pages that aren't coming before carrying on with the unload process.
> 
> Fixes: f019679ea5f2 ("net/mlx5: E-switch, Remove dependency between sriov and eswitch mode")
> 
> Signed-off-by: Daniel Jurgens <danielj@...dia.com>
> Signed-off-by: Saeed Mahameed <saeedm@...dia.com>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/main.c b/drivers/net/ethernet/mellanox/mlx5/core/main.c
> index 540840e80493..f36a3aa4b5c8 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/main.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/main.c
> @@ -1364,8 +1364,8 @@ static void mlx5_unload(struct mlx5_core_dev *dev)
>  {
>  	mlx5_devlink_traps_unregister(priv_to_devlink(dev));
>  	mlx5_sf_dev_table_destroy(dev);
> -	mlx5_sriov_detach(dev);
>  	mlx5_eswitch_disable(dev->priv.eswitch);
> +	mlx5_sriov_detach(dev);
>  	mlx5_lag_remove_mdev(dev);
>  	mlx5_ec_cleanup(dev);
>  	mlx5_sf_hw_table_destroy(dev);
> -- 
> 2.39.2
> 
Looks good, thanks.
Reviewed-by: Piotr Raczynski <piotr.raczynski@...el.com>