netdev - Re: [net 02/14] net/mlx5e: Don't cache tunnel offloads capability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 15 Mar 2023 14:14:20 +0100
From:   Piotr Raczynski <piotr.raczynski@...el.com>
To:     Saeed Mahameed <saeed@...nel.org>
CC:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        "Saeed Mahameed" <saeedm@...dia.com>, <netdev@...r.kernel.org>,
        Tariq Toukan <tariqt@...dia.com>,
        Parav Pandit <parav@...dia.com>,
        Daniel Jurgens <danielj@...dia.com>
Subject: Re: [net 02/14] net/mlx5e: Don't cache tunnel offloads capability

On Tue, Mar 14, 2023 at 10:49:28AM -0700, Saeed Mahameed wrote:
> From: Parav Pandit <parav@...dia.com>
> 
> When mlx5e attaches again after device health recovery, the device
> capabilities might have changed by the eswitch manager.
> 
> For example in one flow when ECPF changes the eswitch mode between
> legacy and switchdev, it updates the flow table tunnel capability.
> 
> The cached value is only used in one place, so just check the capability
> there instead.
> 
> Fixes: 5bef709d76a2 ("net/mlx5: Enable host PF HCA after eswitch is initialized")
> Signed-off-by: Parav Pandit <parav@...dia.com>
> Signed-off-by: Daniel Jurgens <danielj@...dia.com>
> Signed-off-by: Saeed Mahameed <saeedm@...dia.com>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/en.h          | 1 -
>  drivers/net/ethernet/mellanox/mlx5/core/en_main.c     | 4 +---
>  drivers/net/ethernet/mellanox/mlx5/core/en_rep.c      | 1 -
>  drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.c | 1 -
>  4 files changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en.h b/drivers/net/ethernet/mellanox/mlx5/core/en.h
> index 4276c6eb6820..4a19ef4a9811 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en.h
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en.h
> @@ -313,7 +313,6 @@ struct mlx5e_params {
>  		} channel;
>  	} mqprio;
>  	bool rx_cqe_compress_def;
> -	bool tunneled_offload_en;
>  	struct dim_cq_moder rx_cq_moderation;
>  	struct dim_cq_moder tx_cq_moderation;
>  	struct mlx5e_packet_merge_param packet_merge;
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
> index 51b5f3cca504..56fc2aebb9ee 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
> @@ -4979,8 +4979,6 @@ void mlx5e_build_nic_params(struct mlx5e_priv *priv, struct mlx5e_xsk *xsk, u16
>  	/* TX inline */
>  	mlx5_query_min_inline(mdev, &params->tx_min_inline_mode);
>  
> -	params->tunneled_offload_en = mlx5_tunnel_inner_ft_supported(mdev);
> -
>  	/* AF_XDP */
>  	params->xsk = xsk;
>  
> @@ -5285,7 +5283,7 @@ static int mlx5e_init_nic_rx(struct mlx5e_priv *priv)
>  	}
>  
>  	features = MLX5E_RX_RES_FEATURE_PTP;
> -	if (priv->channels.params.tunneled_offload_en)
> +	if (mlx5_tunnel_inner_ft_supported(mdev))
>  		features |= MLX5E_RX_RES_FEATURE_INNER_FT;
>  	err = mlx5e_rx_res_init(priv->rx_res, priv->mdev, features,
>  				priv->max_nch, priv->drop_rq.rqn,
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
> index 43fd12fb87b8..8ff654b4e9e1 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
> @@ -755,7 +755,6 @@ static void mlx5e_build_rep_params(struct net_device *netdev)
>  	mlx5e_set_rx_cq_mode_params(params, cq_period_mode);
>  
>  	params->mqprio.num_tc       = 1;
> -	params->tunneled_offload_en = false;
>  	if (rep->vport != MLX5_VPORT_UPLINK)
>  		params->vlan_strip_disable = true;
>  
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.c b/drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.c
> index c2a4f86bc890..baa7ef812313 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.c
> @@ -70,7 +70,6 @@ static void mlx5i_build_nic_params(struct mlx5_core_dev *mdev,
>  
>  	params->packet_merge.type = MLX5E_PACKET_MERGE_NONE;
>  	params->hard_mtu = MLX5_IB_GRH_BYTES + MLX5_IPOIB_HARD_LEN;
> -	params->tunneled_offload_en = false;
>  
>  	/* CQE compression is not supported for IPoIB */
>  	params->rx_cqe_compress_def = false;
> -- 
> 2.39.2
> 
LGTM, thanks.
Reviewed-by: Piotr Raczynski <piotr.raczynski@...el.com>