netdev - Re: [PATCH net-next v3 2/9] net: sunhme: Remove residual polling code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZBHrOD8Wfr4GPx46@corigine.com>
Date:   Wed, 15 Mar 2023 16:58:48 +0100
From:   Simon Horman <simon.horman@...igine.com>
To:     Sean Anderson <seanga2@...il.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v3 2/9] net: sunhme: Remove residual polling code

On Mon, Mar 13, 2023 at 08:36:06PM -0400, Sean Anderson wrote:
> The sunhme driver never used the hardware MII polling feature. Even the
> if-def'd out happy_meal_poll_start was removed by 2002 [1]. Remove the
> various places in the driver which needlessly guard against MII interrupts
> which will never be enabled.
> 
> [1] https://lwn.net/2002/0411/a/2.5.8-pre3.php3
> 
> Signed-off-by: Sean Anderson <seanga2@...il.com>

Reviewed-by: Simon Horman <simon.horman@...igine.com>