netdev - Re: [PATCH net-next v3 3/9] net: sunhme: Unify IRQ requesting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZBHrVz18X00K88S8@corigine.com>
Date:   Wed, 15 Mar 2023 16:59:19 +0100
From:   Simon Horman <simon.horman@...igine.com>
To:     Sean Anderson <seanga2@...il.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v3 3/9] net: sunhme: Unify IRQ requesting

On Mon, Mar 13, 2023 at 08:36:07PM -0400, Sean Anderson wrote:
> Instead of registering one interrupt handler for all four SBUS Quattro
> HMEs, let each HME register its own handler. To make this work, we don't
> handle the IRQ if none of the status bits are set. This reduces the
> complexity of the driver, and makes it easier to ensure things happen
> before/after enabling IRQs.
> 
> I'm not really sure why we request IRQs in two different places (and leave
> them running after removing the driver!). A lot of things in this driver
> seem to just be crusty, and not necessarily intentional. I'm assuming
> that's the case here as well.
> 
> This really needs to be tested by someone with an SBUS Quattro card.
> 
> Signed-off-by: Sean Anderson <seanga2@...il.com>

Reviewed-by: Simon Horman <simon.horman@...igine.com>