lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230315140454.4329d99e@kernel.org>
Date:   Wed, 15 Mar 2023 14:04:54 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Saeed Mahameed <saeed@...nel.org>
Cc:     Piotr Raczynski <piotr.raczynski@...el.com>,
        "David S. Miller" <davem@...emloft.net>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Saeed Mahameed <saeedm@...dia.com>, netdev@...r.kernel.org,
        Tariq Toukan <tariqt@...dia.com>,
        Parav Pandit <parav@...dia.com>,
        Daniel Jurgens <danielj@...dia.com>
Subject: Re: [net 03/14] net/mlx5: Fix setting ec_function bit in
 MANAGE_PAGES

On Wed, 15 Mar 2023 13:51:46 -0700 Saeed Mahameed wrote:
> >> +static u32 get_ec_function(u32 function)
> >> +{
> >> +	return function >> 16;
> >> +}
> >> +
> >> +static u32 get_func_id(u32 function)
> >> +{
> >> +	return function & 0xffff;
> >> +}
> >> +  
> >Some code in this file is mlx5 'namespaced', some is not. It may be a
> >little easier to follow the code knowing explicitly whether it is driver
> >vs core code, just something to consider.
> 
> For static local file functions we prefer to avoid mlx5 perfix.

FWIW the lack of consistent namespacing does make mlx5 code harder 
for me to read, so it's definitely something to reconsider long term.

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ