netdev - Re: [PATCH] p54spi: convert to devicetree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87jzziwpdi.fsf@kernel.org>
Date:   Wed, 15 Mar 2023 07:32:57 +0200
From:   Kalle Valo <kvalo@...nel.org>
To:     Christian Lamparter <chunkeey@...il.com>
Cc:     Arnd Bergmann <arnd@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <brgl@...ev.pl>,
        linux-gpio@...r.kernel.org, linux-omap@...r.kernel.org,
        Tony Lindgren <tony@...mide.com>,
        Aaro Koskinen <aaro.koskinen@....fi>,
        Felipe Balbi <balbi@...nel.org>, Arnd Bergmann <arnd@...db.de>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Benoît Cousson <bcousson@...libre.com>,
        Russell King <linux@...linux.org.uk>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Johannes Berg <johannes@...solutions.net>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] p54spi: convert to devicetree

Christian Lamparter <chunkeey@...il.com> writes:

> Hi,
>
> On 3/14/23 17:30, Arnd Bergmann wrote:
>> The Prism54 SPI driver hardcodes GPIO numbers and expects users to
>> pass them as module parameters, apparently a relic from its life as a
>> staging driver. This works because there is only one user, the Nokia
>> N8x0 tablet.
>>
>> Convert this to the gpio descriptor interface and move the gpio
>> line information into devicetree to improve this and simplify the
>> code at the same time.
>
> Yes, this is definitely the right idea/way. From what I remember, Kalle
> Valo was partially involved in p54spi/stlc45xx. The details are very fuzzy.
> So,  I could be totally wrong. From what I remember Kalle was working
> for Nokia (or as a contractor for Nokia?) at the time.

I wrote stlc45xx driver as part of my thesis when working for Nokia and
I think then someone wrote p54spi after that. Oh man, this was a long
time ago so hard to remember :)

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches