netdev - Re: [PATCH net 3/3] iavf: do not track VLAN 0 filters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e91b0aa5-4d4d-adc7-b2e3-c36515fb32ee@intel.com>
Date:   Thu, 16 Mar 2023 15:11:04 -0600
From:   Ahmed Zaki <ahmed.zaki@...el.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     Leon Romanovsky <leon@...nel.org>,
        Tony Nguyen <anthony.l.nguyen@...el.com>,
        <davem@...emloft.net>, <pabeni@...hat.com>, <edumazet@...gle.com>,
        <netdev@...r.kernel.org>, Michal Kubiak <michal.kubiak@...el.com>,
        Rafal Romanowski <rafal.romanowski@...el.com>
Subject: Re: [PATCH net 3/3] iavf: do not track VLAN 0 filters


On 2023-03-16 14:59, Jakub Kicinski wrote:
> On Thu, 16 Mar 2023 07:15:32 -0600 Ahmed Zaki wrote:
>>> I would expect similar check in iavf_vlan_rx_kill_vid(),
>> Thanks for review. Next version will include the check in
>> iavf_vlan_rx_kill_vid()
> FWIW it is okay to ask more clarifying questions / push back
> a little. I had a quick look and calling iavf_vlan_rx_kill_vid()
> with vid of 0 does not seem harmful. Or any vid that was not added
> earlier. So it's down to personal preference. I see v2 is already
> out but just for future reference..

Thanks. I had the same thoughts, but then the extra check still saves 
few cycles (the function trying to find the VID), so I added it.