netdev - Re: [PATCH bpf v3] xsk: Add missing overflow check in xdp_umem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8a076362-c98e-9268-47bd-91f5f8e57449@iogearbox.net>
Date:   Thu, 16 Mar 2023 22:13:59 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Magnus Karlsson <magnus.karlsson@...il.com>,
        Kal Conley <kal.conley@...tris.com>
Cc:     Björn Töpel <bjorn@...nel.org>,
        Magnus Karlsson <magnus.karlsson@...el.com>,
        Maciej Fijalkowski <maciej.fijalkowski@...el.com>,
        Jonathan Lemon <jonathan.lemon@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        John Fastabend <john.fastabend@...il.com>,
        netdev@...r.kernel.org, bpf@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH bpf v3] xsk: Add missing overflow check in xdp_umem_reg

On 3/16/23 1:52 PM, Magnus Karlsson wrote:
> On Wed, 8 Mar 2023 at 18:51, Kal Conley <kal.conley@...tris.com> wrote:
>>
>> The number of chunks can overflow u32. Make sure to return -EINVAL on
>> overflow.
>>
>> Also remove a redundant u32 cast assigning umem->npgs.
> 
> Thanks!
> 
> Acked-by: Magnus Karlsson <magnus.karlsson@...el.com>
> 
>> Fixes: bbff2f321a86 ("xsk: new descriptor addressing scheme")
>> Signed-off-by: Kal Conley <kal.conley@...tris.com>

Looks like patchbot was on partial strike, this was applied to bpf, thanks!