netdev - Re: [PATCH net v2] tools: ynl: Add missing types to encode/decode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230315214357.74396015@kernel.org>
Date:   Wed, 15 Mar 2023 21:43:57 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Michal Michalik <michal.michalik@...el.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, pabeni@...hat.com,
        edumazet@...gle.com, arkadiusz.kubalewski@...el.com
Subject: Re: [PATCH net v2] tools: ynl: Add missing types to encode/decode

On Wed, 15 Mar 2023 13:08:52 +0100 Michal Michalik wrote:
> While testing the tool I noticed we miss the u16 type on payload create.
> On the code inspection it turned out we miss also u8 and u64 - add them.
> 
> We also miss the decoding of u16 despite the fact `NlAttr` class
> supports it - add it.

Do we have any spec upstream which needs these?
The patch looks good, but I think net-next is good enough?

> Fixes: e4b48ed460d3 ("tools: ynl: add a completely generic client")
> Signed-off-by: Michal Michalik <michal.michalik@...el.com>
> 
> ---

Please make sure there's no empty lines between the tags and the ---
separator, it confuses the scripts.