netdev - RE: [PATCH net v2] tools: ynl: Add missing types to encode/decode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BN6PR11MB4177DBAC7674FB5321D6F63AE3809@BN6PR11MB4177.namprd11.prod.outlook.com>
Date:   Mon, 20 Mar 2023 19:14:36 +0000
From:   "Michalik, Michal" <michal.michalik@...el.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "Kubalewski, Arkadiusz" <arkadiusz.kubalewski@...el.com>
Subject: RE: [PATCH net v2] tools: ynl: Add missing types to encode/decode

From: Jakub Kicinski <kuba@...nel.org> 
Sent: Thursday, March 16, 2023 5:44 AM
> 
> On Wed, 15 Mar 2023 13:08:52 +0100 Michal Michalik wrote:
>> While testing the tool I noticed we miss the u16 type on payload create.
>> On the code inspection it turned out we miss also u8 and u64 - add them.
>> 
>> We also miss the decoding of u16 despite the fact `NlAttr` class
>> supports it - add it.
> 
> Do we have any spec upstream which needs these?
> The patch looks good, but I think net-next is good enough?
> 

Yes, I faced this issue while testing the tool for the DPLL interface
upstream efforts: (needed only u16, but fixed all missing)
https://lore.kernel.org/netdev/20230312022807.278528-4-vadfed@meta.com/T/

I agree - net-next should be sufficient, I will change the tree and
resend it.

>> Fixes: e4b48ed460d3 ("tools: ynl: add a completely generic client")
>> Signed-off-by: Michal Michalik <michal.michalik@...el.com>
>> 
>> ---
> 
> Please make sure there's no empty lines between the tags and the ---
> separator, it confuses the scripts.
> 

Ohh - please excuse me, I was not aware of that. I will keep that in mind.