netdev - Re: [PATCH net-next v2] net/sched: act_api: use the correct TCA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZBTR4LONsxdn9l/5@corigine.com>
Date:   Fri, 17 Mar 2023 21:47:28 +0100
From:   Simon Horman <simon.horman@...igine.com>
To:     Pedro Tammela <pctammela@...atatu.com>
Cc:     netdev@...r.kernel.org, jhs@...atatu.com, xiyou.wangcong@...il.com,
        jiri@...nulli.us, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, Hangbin Liu <haliu@...hat.com>
Subject: Re: [PATCH net-next v2] net/sched: act_api: use the correct TCA_ACT
 attributes in dump

On Fri, Mar 17, 2023 at 04:35:19PM -0300, Pedro Tammela wrote:
> 3 places in the act api code are using 'TCA_' definitions where they should be using
> 'TCA_ACT_', which is confusing for the reader, although functionaly wise they are equivalent.

nit1: 'functionaly wise' -> 'functionally'
nit2: text is more than 75 columns wide

> Cc: Hangbin Liu <haliu@...hat.com>
> Reviewed-by: Jamal Hadi Salim <jhs@...atatu.com>
> Signed-off-by: Pedro Tammela <pctammela@...atatu.com>

Code changes look good to me.

Reviewed-by: Simon Horman <simon.horman@...igine.com>