netdev - Re: [PATCH v13 0/4] Add support for NXP bluetooth chipsets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABBYNZJG3T+v=RdQBuW-zvDDCQpqdkn3K=fP3NkPECJQdLbo9A@mail.gmail.com>
Date:   Fri, 17 Mar 2023 13:48:03 -0700
From:   Luiz Augusto von Dentz <luiz.dentz@...il.com>
To:     Simon Horman <simon.horman@...igine.com>
Cc:     Neeraj Sanjay Kale <neeraj.sanjaykale@....com>,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, marcel@...tmann.org,
        johan.hedberg@...il.com, gregkh@...uxfoundation.org,
        jirislaby@...nel.org, alok.a.tiwari@...cle.com, hdanton@...a.com,
        ilpo.jarvinen@...ux.intel.com, leon@...nel.org,
        netdev@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-bluetooth@...r.kernel.org,
        linux-serial@...r.kernel.org, amitkumar.karwar@....com,
        rohit.fule@....com, sherry.sun@....com
Subject: Re: [PATCH v13 0/4] Add support for NXP bluetooth chipsets

Hi Simon,

On Fri, Mar 17, 2023 at 1:42 PM Simon Horman <simon.horman@...igine.com> wrote:
>
> On Fri, Mar 17, 2023 at 01:00:11PM -0700, Luiz Augusto von Dentz wrote:
> > Hi Neeraj,
> >
> > On Thu, Mar 16, 2023 at 10:22 AM Neeraj Sanjay Kale
> > <neeraj.sanjaykale@....com> wrote:
> > >
> > > This patch adds a driver for NXP bluetooth chipsets.
> > >
> > > The driver is based on H4 protocol, and uses serdev APIs. It supports host
> > > to chip power save feature, which is signalled by the host by asserting
> > > break over UART TX lines, to put the chip into sleep state.
> > >
> > > To support this feature, break_ctl has also been added to serdev-tty along
> > > with a new serdev API serdev_device_break_ctl().
> > >
> > > This driver is capable of downloading firmware into the chip over UART.
> > >
> > > The document specifying device tree bindings for this driver is also
> > > included in this patch series.
> > >
> > > Neeraj Sanjay Kale (4):
> > >   serdev: Replace all instances of ENOTSUPP with EOPNOTSUPP
> > >   serdev: Add method to assert break signal over tty UART port
> > >   dt-bindings: net: bluetooth: Add NXP bluetooth support
> > >   Bluetooth: NXP: Add protocol support for NXP Bluetooth chipsets
> > >
> > >  .../net/bluetooth/nxp,88w8987-bt.yaml         |   45 +
> > >  MAINTAINERS                                   |    7 +
> > >  drivers/bluetooth/Kconfig                     |   12 +
> > >  drivers/bluetooth/Makefile                    |    1 +
> > >  drivers/bluetooth/btnxpuart.c                 | 1297 +++++++++++++++++
> > >  drivers/tty/serdev/core.c                     |   17 +-
> > >  drivers/tty/serdev/serdev-ttyport.c           |   16 +-
> > >  include/linux/serdev.h                        |   10 +-
> > >  8 files changed, 1398 insertions(+), 7 deletions(-)
> > >  create mode 100644 Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> > >  create mode 100644 drivers/bluetooth/btnxpuart.c
> > >
> > > --
> > > 2.34.1
> >
> > If there are no new comments to be addressed by the end of the day I'm
> > planning to merge this into bluetooth-next.
>
> FWIIW, as someone involved in the review of this series, I am fine with that.
> Even though I have only supplied tags for some of the patches;
> those for which I feel that it is appropriate.

Thanks for the feedback and the review as well.


-- 
Luiz Augusto von Dentz