netdev - Re: [PATCH] ethernet: sun: add check for the mdesc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230317222944.64f66377@kernel.org>
Date:   Fri, 17 Mar 2023 22:29:44 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Liang He <windhl@....com>
Cc:     davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH] ethernet: sun: add check for the mdesc_grab()

On Wed, 15 Mar 2023 14:00:21 +0800 Liang He wrote:
>  	hp = mdesc_grab();
>  
> +	if (!hp)
> +		return -ENODEV;

no empty line between the function call and error check, please