netdev - Re:Re: [PATCH] ethernet: sun: add check for the mdesc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2ddbb6b4.1453.186f9a2a1f0.Coremail.windhl@126.com>
Date:   Sun, 19 Mar 2023 19:30:30 +0800 (CST)
From:   "Liang He" <windhl@....com>
To:     "Jakub Kicinski" <kuba@...nel.org>
Cc:     davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
        netdev@...r.kernel.org
Subject: Re:Re: [PATCH] ethernet: sun: add check for the mdesc_grab()


At 2023-03-18 13:29:44, "Jakub Kicinski" <kuba@...nel.org> wrote:
>On Wed, 15 Mar 2023 14:00:21 +0800 Liang He wrote:
>>  	hp = mdesc_grab();
>>  
>> +	if (!hp)
>> +		return -ENODEV;
>
>no empty line between the function call and error check, please

Hi, Jakub,

Thanks very much for your review and reply.

While I have already prepared the new version patch,  my last patch
has been Reviewed-by Piotr Raczynski and applied to netdev/net.git
by David S.Miller.

So should I send the new patch again? 


Thanks,

Liang