netdev - RE: [PATCH net] r8169: fix rtl8168h rx crc error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3892d440f0194b30aa32ccd93f661dd2@realtek.com>
Date:   Wed, 22 Mar 2023 12:13:12 +0000
From:   Hau <hau@...ltek.com>
To:     Horatiu Vultur <horatiu.vultur@...rochip.com>
CC:     "hkallweit1@...il.com" <hkallweit1@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        nic_swsd <nic_swsd@...ltek.com>
Subject: RE: [PATCH net] r8169: fix rtl8168h rx crc error

> The 03/22/2023 14:45, ChunHao Lin wrote:
> >
> > When link speed is 10 Mbps and temperature is under -20°C, rtl8168h
> > may have rx crc error. Disable phy 10 Mbps pll off to fix this issue.
> 
> Don't forget to add the fixes tag.
> Another comment that I usually get is to replace hardcoded values with
> defines, but on the other side I can see that this file already has plently of
> hardcoded values.
> 
It is not a fix for a specific commit. PHY 10m pll off is an power saving feature which is enabled by H/W default.
This issue can be fixed by disable PHY 10m pll off.

> Reviewed-by: Horatiu Vultur <horatiu.vultur@...rochip.com>
> 
> >
> > Signed-off-by: ChunHao Lin <hau@...ltek.com>
> > ---
> >  drivers/net/ethernet/realtek/r8169_phy_config.c | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/net/ethernet/realtek/r8169_phy_config.c
> > b/drivers/net/ethernet/realtek/r8169_phy_config.c
> > index 930496cd34ed..b50f16786c24 100644
> > --- a/drivers/net/ethernet/realtek/r8169_phy_config.c
> > +++ b/drivers/net/ethernet/realtek/r8169_phy_config.c
> > @@ -826,6 +826,9 @@ static void rtl8168h_2_hw_phy_config(struct
> rtl8169_private *tp,
> >         /* disable phy pfm mode */
> >         phy_modify_paged(phydev, 0x0a44, 0x11, BIT(7), 0);
> >
> > +       /* disable 10m pll off */
> > +       phy_modify_paged(phydev, 0x0a43, 0x10, BIT(0), 0);
> > +
> >         rtl8168g_disable_aldps(phydev);
> >         rtl8168g_config_eee_phy(phydev);  }
> > --
> > 2.37.2
> >
> 
> --
> /Horatiu
> 
> ------Please consider the environment before printing this e-mail.