netdev - Re: [PATCH net] r8169: fix rtl8168h rx crc error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230322125934.102876c1@kernel.org>
Date:   Wed, 22 Mar 2023 12:59:34 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Hau <hau@...ltek.com>
Cc:     Horatiu Vultur <horatiu.vultur@...rochip.com>,
        "hkallweit1@...il.com" <hkallweit1@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        nic_swsd <nic_swsd@...ltek.com>
Subject: Re: [PATCH net] r8169: fix rtl8168h rx crc error

On Wed, 22 Mar 2023 12:13:12 +0000 Hau wrote:
> > Don't forget to add the fixes tag.
> > Another comment that I usually get is to replace hardcoded values with
> > defines, but on the other side I can see that this file already has plently of
> > hardcoded values.
>  
> It is not a fix for a specific commit. PHY 10m pll off is an power
> saving feature which is enabled by H/W default. This issue can be
> fixed by disable PHY 10m pll off.

How far back can the issue be reproduced? Is it only possible with
certain device types? Then the Fixes tag should point at the commit
which added support for the devices. Was it always present since 2.6
kernels? Put the first commit in the git history as Fixes.