netdev - Re: [PATCH net-next 2/2] net: ethernet: mediatek: mtk_ppe: prefer newly added l2 flows over existing ones

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c6c52acc-0203-f4e5-a368-850d9f459b08@nbd.name>
Date:   Wed, 22 Mar 2023 16:09:25 +0100
From:   Felix Fietkau <nbd@....name>
To:     Simon Horman <simon.horman@...igine.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next 2/2] net: ethernet: mediatek: mtk_ppe: prefer
 newly added l2 flows over existing ones

On 22.03.23 15:00, Simon Horman wrote:
> On Tue, Mar 21, 2023 at 02:36:09PM +0100, Felix Fietkau wrote:
>> When a device is roaming between interfaces and a new flow entry is created,
>> we should assume that its output device is more up to date than whatever
>> entry existed already.
> 
> As per patch 1/2. checkpatch complains that the patch description
> has lines more than 75 characters long.
Will do.

> That aside, this change looks good to me.
> But I'm wondering if it is fixing a bug.
> Or just improving something suboptimal (form a user experience POV).
In my opinion, this is just an improvement, not a bugfix.

Thanks,

- Felix