netdev - Re: [PATCH net-next] ipv6: prevent router

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZBxlI7LSDKgxAw3Q@corigine.com>
Date:   Thu, 23 Mar 2023 15:41:39 +0100
From:   Simon Horman <simon.horman@...igine.com>
To:     Xin Long <lucien.xin@...il.com>
Cc:     network dev <netdev@...r.kernel.org>, davem@...emloft.net,
        kuba@...nel.org, Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        David Ahern <dsahern@...il.com>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        Jiri Pirko <jiri@...nulli.us>
Subject: Re: [PATCH net-next] ipv6: prevent router_solicitations for team port

On Wed, Mar 22, 2023 at 07:35:41PM -0400, Xin Long wrote:
> The issue fixed for bonding in commit c2edacf80e15 ("bonding / ipv6: no
> addrconf for slaves separately from master") also exists in team driver.
> However, we can't just disable ipv6 addrconf for team ports, as 'teamd'
> will need it when nsns_ping watch is used in the user space.
> 
> Instead of preventing ipv6 addrconf, this patch only prevents RS packets
> for team ports, as it did in commit b52e1cce31ca ("ipv6: Don't send rs
> packets to the interface of ARPHRD_TUNNEL").
> 
> Note that we do not prevent DAD packets, to avoid the changes getting
> intricate / hacky. Also, usually sysctl dad_transmits is set to 1 and
> only 1 DAD packet will be sent, and by now no libteam user complains
> about DAD packets on team ports, unlike RS packets.
> 
> Signed-off-by: Xin Long <lucien.xin@...il.com>

Reviewed-by: Simon Horman <simon.horman@...igine.com>