netdev - Re: [PATCH] mISDN: remove unused vpm_read_address and cpld_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZBycfvJT1cZe3kKs@corigine.com>
Date:   Thu, 23 Mar 2023 19:37:50 +0100
From:   Simon Horman <simon.horman@...igine.com>
To:     Tom Rix <trix@...hat.com>
Cc:     isdn@...ux-pingi.de, nathan@...nel.org, ndesaulniers@...gle.com,
        yangyingliang@...wei.com, alexanderduyck@...com, kuba@...nel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        llvm@...ts.linux.dev
Subject: Re: [PATCH] mISDN: remove unused vpm_read_address and cpld_read_reg
 functions

On Thu, Mar 23, 2023 at 12:13:43PM -0400, Tom Rix wrote:
> clang with W=1 reports
> drivers/isdn/hardware/mISDN/hfcmulti.c:667:1: error: unused function
>   'vpm_read_address' [-Werror,-Wunused-function]
> vpm_read_address(struct hfc_multi *c)
> ^
> 
> drivers/isdn/hardware/mISDN/hfcmulti.c:643:1: error: unused function
>   'cpld_read_reg' [-Werror,-Wunused-function]
> cpld_read_reg(struct hfc_multi *hc, unsigned char reg)
> ^
> 
> These functions are not used, so remove them.
> 
> Reported-by: Simon Horman <simon.horman@...igine.com>

FWIIW, says this should go here.

Link: https://lore.kernel.org/netdev/ZBsArtzFkgz+05LK@corigine.com/

> Signed-off-by: Tom Rix <trix@...hat.com>

Patch looks good, thanks.

Reviewed-by: Simon Horman <simon.horman@...igine.com>