netdev - Re: [PATCH net-next v2 4/4] tools: ynl: ethtool testing tool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230324203543.3998a487@kernel.org>
Date:   Fri, 24 Mar 2023 20:35:43 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Stanislav Fomichev <sdf@...gle.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
        pabeni@...hat.com
Subject: Re: [PATCH net-next v2 4/4] tools: ynl: ethtool testing tool

On Fri, 24 Mar 2023 15:56:56 -0700 Stanislav Fomichev wrote:
> +def args_to_req(ynl, op_name, args, req):
> +  """
> +  Verify and convert command-line arguments to the ynl-compatible request.
> +  """
> +  valid_attrs = ynl.operation_do_attributes(op_name)
> +  valid_attrs.remove('header') # not user-provided
> +
> +  if len(args) == 0:
> +    print(f'no attributes, expected: {valid_attrs}')
> +    sys.exit(1)

Could you re-format with 4 char indentation? To keep it consistent with
the rest of ynl?