netdev - Re: [PATCH net-next v2 4/4] tools: ynl: ethtool testing tool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKH8qBsGotuK2brjmtZXmdXitbCJ532o18c4Rfhu_B993kcWGw@mail.gmail.com>
Date:   Tue, 28 Mar 2023 17:06:57 -0700
From:   Stanislav Fomichev <sdf@...gle.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
        pabeni@...hat.com
Subject: Re: [PATCH net-next v2 4/4] tools: ynl: ethtool testing tool

On Fri, Mar 24, 2023 at 8:35 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Fri, 24 Mar 2023 15:56:56 -0700 Stanislav Fomichev wrote:
> > +def args_to_req(ynl, op_name, args, req):
> > +  """
> > +  Verify and convert command-line arguments to the ynl-compatible request.
> > +  """
> > +  valid_attrs = ynl.operation_do_attributes(op_name)
> > +  valid_attrs.remove('header') # not user-provided
> > +
> > +  if len(args) == 0:
> > +    print(f'no attributes, expected: {valid_attrs}')
> > +    sys.exit(1)
>
> Could you re-format with 4 char indentation? To keep it consistent with
> the rest of ynl?

Sorry, I was somehow assuming that whatever my vim does is the right
way to go :-( Fixed my config and will reindent.