netdev - Re: [syzbot] [net?] [virt?] [io-uring?] [kvm?] BUG: soft lockup in vsock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZCCbATwov4U+GBUv@pop-os.localdomain>
Date:   Sun, 26 Mar 2023 12:20:33 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Bobby Eshleman <bobbyeshleman@...il.com>
Cc:     Stefano Garzarella <sgarzare@...hat.com>,
        Bobby Eshleman <bobby.eshleman@...edance.com>,
        Bobby Eshleman <bobby.eshleman@...il.com>,
        syzbot <syzbot+0bc015ebddc291a97116@...kaller.appspotmail.com>,
        axboe@...nel.dk, davem@...emloft.net, edumazet@...gle.com,
        io-uring@...r.kernel.org, kuba@...nel.org, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        pabeni@...hat.com, stefanha@...hat.com,
        syzkaller-bugs@...glegroups.com,
        virtualization@...ts.linux-foundation.org,
        Krasnov Arseniy <oxffffaa@...il.com>,
        Krasnov Arseniy Vladimirovich <AVKrasnov@...rdevices.ru>
Subject: Re: [syzbot] [net?] [virt?] [io-uring?] [kvm?] BUG: soft lockup in
 vsock_connect

On Sat, Mar 18, 2023 at 12:32:39AM +0000, Bobby Eshleman wrote:
> On Fri, Mar 24, 2023 at 09:38:38AM +0100, Stefano Garzarella wrote:
> > Hi Bobby,
> > FYI we have also this one, but it seems related to
> > syzbot+befff0a9536049e7902e@...kaller.appspotmail.com
> > 
> > Thanks,
> > Stefano
> > 
> 
> Got it, I'll look into it.
> 

It seems you forgot to set skb->sk??

diff --git a/net/vmw_vsock/virtio_transport_common.c b/net/vmw_vsock/virtio_transport_common.c
index 957cdc01c8e8..d47ad27b409d 100644
--- a/net/vmw_vsock/virtio_transport_common.c
+++ b/net/vmw_vsock/virtio_transport_common.c
@@ -236,6 +236,7 @@ static int virtio_transport_send_pkt_info(struct vsock_sock *vsk,
        }

        virtio_transport_inc_tx_pkt(vvs, skb);
+       skb_set_owner_w(skb, sk_vsock(vsk));

        return t_ops->send_pkt(skb);
 }