netdev - Re: [PATCH net-next v3 5/8] ice: remove redundant SRIOV code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZCBKVN8x8aQ2SY9x@corigine.com>
Date:   Sun, 26 Mar 2023 15:36:20 +0200
From:   Simon Horman <simon.horman@...igine.com>
To:     Piotr Raczynski <piotr.raczynski@...el.com>
Cc:     intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
        michal.swiatkowski@...el.com, shiraz.saleem@...el.com,
        jacob.e.keller@...el.com, sridhar.samudrala@...el.com,
        jesse.brandeburg@...el.com, aleksander.lobakin@...el.com,
        lukasz.czapnik@...el.com,
        Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
Subject: Re: [PATCH net-next v3 5/8] ice: remove redundant SRIOV code

On Thu, Mar 23, 2023 at 01:24:37PM +0100, Piotr Raczynski wrote:
> Remove redundant code from ice_get_max_valid_res_idx that has no effect.
> ice_pf::irq_tracker is initialized during driver probe, there is no reason
> to check it again. Also it is not possible for pf::sriov_base_vector to be
> lower than the tracker length, remove WARN_ON that will never happen.
> 
> Get rid of ice_get_max_valid_res_idx helper function completely since it
> can never return negative value.
> 
> Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
> Signed-off-by: Piotr Raczynski <piotr.raczynski@...el.com>

Reviewed-by: Simon Horman <simon.horman@...igine.com>