netdev - Re: [PATCH net-next v3 8/8] ice: add dynamic interrupt allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZCBKhOs5Ios301mk@corigine.com>
Date:   Sun, 26 Mar 2023 15:37:08 +0200
From:   Simon Horman <simon.horman@...igine.com>
To:     Piotr Raczynski <piotr.raczynski@...el.com>
Cc:     intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
        michal.swiatkowski@...el.com, shiraz.saleem@...el.com,
        jacob.e.keller@...el.com, sridhar.samudrala@...el.com,
        jesse.brandeburg@...el.com, aleksander.lobakin@...el.com,
        lukasz.czapnik@...el.com,
        Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
Subject: Re: [PATCH net-next v3 8/8] ice: add dynamic interrupt allocation

On Thu, Mar 23, 2023 at 01:24:40PM +0100, Piotr Raczynski wrote:
> Currently driver can only allocate interrupt vectors during init phase by
> calling pci_alloc_irq_vectors. Change that and make use of new
> pci_msix_alloc_irq_at/pci_msix_free_irq API and enable to allocate and free
> more interrupts after MSIX has been enabled. Since not all platforms
> supports dynamic allocation, check it with pci_msix_can_alloc_dyn.
> 
> Extend the tracker to keep track how many interrupts are allocated
> initially so when all such vectors are already used, additional interrupts
> are automatically allocated dynamically. Remember each interrupt allocation
> method to then free appropriately. Since some features may require
> interrupts allocated dynamically add appropriate VSI flag and take it into
> account when allocating new interrupt.
> 
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
> Signed-off-by: Piotr Raczynski <piotr.raczynski@...el.com>

Reviewed-by: Simon Horman <simon.horman@...igine.com>