netdev - Re: [PATCH net-next 1/6] mlxsw: reg: Move 'mpsc' definition in 'mlxsw_reg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 26 Mar 2023 15:59:45 +0200
From:   Simon Horman <simon.horman@...igine.com>
To:     Petr Machata <petrm@...dia.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        Ido Schimmel <idosch@...dia.com>,
        Amit Cohen <amcohen@...dia.com>, mlxsw@...dia.com
Subject: Re: [PATCH net-next 1/6] mlxsw: reg: Move 'mpsc' definition in
 'mlxsw_reg_infos'

On Wed, Mar 22, 2023 at 05:49:30PM +0100, Petr Machata wrote:
> From: Amit Cohen <amcohen@...dia.com>
> 
> The array 'mlxsw_reg_infos' is ordered by registers' IDs. The ID of MPSC
> register is 0x9080, so it should be after MCDA (register ID 0x9063) and
> not after MTUTC (register ID 0x9055). Note that the register's fields are
> defined in the correct place in the file, only the definition in
> 'mlxsw_reg_infos' is wrong. This issue was found while adding new
> register which supposed to be before mpsc.
> 
> Signed-off-by: Amit Cohen <amcohen@...dia.com>
> Reviewed-by: Ido Schimmel <idosch@...dia.com>
> Reviewed-by: Petr Machata <petrm@...dia.com>
> Signed-off-by: Petr Machata <petrm@...dia.com>

Reviewed-by: Simon Horman <simon.horman@...igine.com>