lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <72849de7-1acc-00e0-5e82-3e62ddcd54fd@gmail.com> Date: Tue, 28 Mar 2023 05:10:19 +0100 From: Edward Cree <ecree.xilinx@...il.com> To: Íñigo Huguet <ihuguet@...hat.com>, habetsm.xilinx@...il.com Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, richardcochran@...il.com, netdev@...r.kernel.org, Yalin Li <yalli@...hat.com> Subject: Re: [PATCH v5 net-next 3/4] sfc: support unicast PTP On 27/03/2023 11:57, Íñigo Huguet wrote: > When sending a PTP event packet, add the correct filters that will make > that future incoming unicast PTP event packets will be timestamped. > The unicast address for the filter is gotten from the outgoing skb > before sending it. > > Until now they were not timestamped because only filters that match with > the PTP multicast addressed were being configured into the NIC for the > PTP special channel. Packets received through different channels are not > timestamped, getting "received SYNC without timestamp" error in ptp4l. > > Note that the inserted filters are never removed unless the NIC is stopped > or reconfigured, so efx_ptp_stop is called. Removal of old filters will > be handled by the next patch. > > Additionally, cleanup a bit efx_ptp_xmit_skb_mc to use the reverse xmas > tree convention and remove an unnecessary assignment to rc variable in > void function. > > Reported-by: Yalin Li <yalli@...hat.com> > Signed-off-by: Íñigo Huguet <ihuguet@...hat.com> > --- Reviewed-by: Edward Cree <ecree.xilinx@...il.com>
Powered by blists - more mailing lists