netdev - Re: [PATCH net-next] bonding: add software timestamping support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZCQSf6Sc8A8E9ERN@localhost>
Date:   Wed, 29 Mar 2023 12:27:11 +0200
From:   Miroslav Lichvar <mlichvar@...hat.com>
To:     Hangbin Liu <liuhangbin@...il.com>
Cc:     netdev@...r.kernel.org, Jay Vosburgh <j.vosburgh@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Jonathan Toppins <jtoppins@...hat.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Richard Cochran <richardcochran@...il.com>
Subject: Re: [PATCH net-next] bonding: add software timestamping support

On Wed, Mar 29, 2023 at 11:13:37AM +0800, Hangbin Liu wrote:
> At present, bonding attempts to obtain the timestamp (ts) information of
> the active slave. However, this feature is only available for mode 1, 5,
> and 6. For other modes, bonding doesn't even provide support for software
> timestamping. To address this issue, let's call ethtool_op_get_ts_info
> when there is no primary active slave. This will enable the use of software
> timestamping for the bonding interface.

Would it make sense to check if all devices in the bond support
SOF_TIMESTAMPING_TX_SOFTWARE before returning it for the bond?
Applications might expect that a SW TX timestamp will be always
provided if the capability is reported.

-- 
Miroslav Lichvar