netdev - Re: [PATCH net-next] bonding: add software timestamping support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <26873.1680061018@famine>
Date:   Tue, 28 Mar 2023 20:36:58 -0700
From:   Jay Vosburgh <jay.vosburgh@...onical.com>
To:     Hangbin Liu <liuhangbin@...il.com>
cc:     netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Jonathan Toppins <jtoppins@...hat.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Miroslav Lichvar <mlichvar@...hat.com>,
        Richard Cochran <richardcochran@...il.com>
Subject: Re: [PATCH net-next] bonding: add software timestamping support

Hangbin Liu <liuhangbin@...il.com> wrote:

>At present, bonding attempts to obtain the timestamp (ts) information of
>the active slave. However, this feature is only available for mode 1, 5,
>and 6. For other modes, bonding doesn't even provide support for software
>timestamping. To address this issue, let's call ethtool_op_get_ts_info
>when there is no primary active slave. This will enable the use of software
>timestamping for the bonding interface.

	If I'm reading the patch below correctly, the actual functional
change here is to additionally set SOF_TIMESTAMPING_TX_SOFTWARE in
so_timestamping for the active-backup, balance-tlb and balance-alb modes
(or whenever there's no active slave, but that's less interesting).  So,
this patch only changes the behavior with regards to transmit
timestamping, correct?

	I'm not objecting to the patch per se, but the description above
does not appear to correctly describe the change.

	-J

>Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
>---
> drivers/net/bonding/bond_main.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
>diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
>index 00646aa315c3..f0856bec59f5 100644
>--- a/drivers/net/bonding/bond_main.c
>+++ b/drivers/net/bonding/bond_main.c
>@@ -5709,9 +5709,7 @@ static int bond_ethtool_get_ts_info(struct net_device *bond_dev,
> 		}
> 	}
> 
>-	info->so_timestamping = SOF_TIMESTAMPING_RX_SOFTWARE |
>-				SOF_TIMESTAMPING_SOFTWARE;
>-	info->phc_index = -1;
>+	ret = ethtool_op_get_ts_info(bond_dev, info);
> 
> out:
> 	dev_put(real_dev);
>-- 
>2.38.1
>

---
	-Jay Vosburgh, jay.vosburgh@...onical.com