netdev - Re: [PATCH net-next 0/4] devlink: Add port function attributes to enable/disable IPsec crypto and packet offloads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 29 Mar 2023 10:09:38 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Leon Romanovsky <leon@...nel.org>
Cc:     Dima Chumak <dchumak@...dia.com>, Jiri Pirko <jiri@...nulli.us>,
        Saeed Mahameed <saeedm@...dia.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 0/4] devlink: Add port function attributes to
 enable/disable IPsec crypto and packet offloads

On Wed, 29 Mar 2023 10:45:37 +0300 Leon Romanovsky wrote:
> On Thu, Mar 23, 2023 at 10:05:56AM -0700, Jakub Kicinski wrote:
> > On Thu, 23 Mar 2023 13:10:55 +0200 Dima Chumak wrote:  
> > > Currently, mlx5 PCI VFs are disabled by default for IPsec functionality.
> > > A user does not have the ability to enable IPsec support for a PCI VF
> > > device.  
> > 
> > Could Mellanox/nVidia figure out a why to get folks trained on posting
> > patches correctly? IDK how to do that exactly but you have a rather
> > large employee base, it may be most efficient if you handle that
> > internally than the community teaching people one by one.  
> 
> IDK why Dima postes like he posted, but we guide people and provide nice playground
> to test submissions internally, but it is not enough. There are always nuances in
> submission as rules constantly evolve.

I'd say that we try to improve the documentation these days more 
than evolve the rules. The suggestion for how to post user space
is 2.5 years old:

commit 6f7a1f9c1af30f1eadc0ad9e77ec8ee95c48b2c9
Author: Jakub Kicinski <kuba@...nel.org>
Date:   Tue Nov 24 20:15:24 2020 -0800

    Documentation: netdev-FAQ: suggest how to post co-dependent series

> > Or perhaps there's something we can do to improve community docs?  
> 
> People don't read them :)

We can make them, but then we'll be the bad guys again :(