netdev - Re: [PATCH 1/5] iio: adc: ad7292: Add explicit include for of.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230330093805.00003bb4@Huawei.com>
Date:   Thu, 30 Mar 2023 09:38:05 +0100
From:   Jonathan Cameron <Jonathan.Cameron@...wei.com>
To:     Marcelo Schmitt <marcelo.schmitt1@...il.com>
CC:     Rob Herring <robh@...nel.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Len Brown <lenb@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        "Michael Hennerich" <Michael.Hennerich@...log.com>,
        Jonathan Cameron <jic23@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Johannes Berg <johannes@...solutions.net>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Jiri Slaby <jirislaby@...nel.org>,
        Thierry Reding <thierry.reding@...il.com>,
        "Jonathan Hunter" <jonathanh@...dia.com>,
        Marc Zyngier <maz@...nel.org>, <linux-iio@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-staging@...ts.linux.dev>,
        <linux-wireless@...r.kernel.org>, <netdev@...r.kernel.org>,
        <linux-serial@...r.kernel.org>, <linux-tegra@...r.kernel.org>,
        <linux-acpi@...r.kernel.org>, <devicetree@...r.kernel.org>
Subject: Re: [PATCH 1/5] iio: adc: ad7292: Add explicit include for of.h

On Wed, 29 Mar 2023 22:10:55 -0300
Marcelo Schmitt <marcelo.schmitt1@...il.com> wrote:

> On 03/29, Rob Herring wrote:
> > With linux/acpi.h no longer implicitly including of.h, add an explicit
> > include of of.h to fix the following error:
> > 
> > drivers/iio/adc/ad7292.c:307:9: error: implicit declaration of function 'for_each_available_child_of_node'; did you mean 'fwnode_for_each_available_child_node'? [-Werror=implicit-function-declaration]
> > 
> > Signed-off-by: Rob Herring <robh@...nel.org>  
> 
> Acked-by: Marcelo Schmitt <marcelo.schmitt1@...il.com>
Acked-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>

> 
> Thanks,
> Marcelo
> 
> > ---
> >  drivers/iio/adc/ad7292.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/iio/adc/ad7292.c b/drivers/iio/adc/ad7292.c
> > index a2f9fda25ff3..cccacec5db6d 100644
> > --- a/drivers/iio/adc/ad7292.c
> > +++ b/drivers/iio/adc/ad7292.c
> > @@ -8,6 +8,7 @@
> >  #include <linux/bitfield.h>
> >  #include <linux/device.h>
> >  #include <linux/module.h>
> > +#include <linux/of.h>
> >  #include <linux/regulator/consumer.h>
> >  #include <linux/spi/spi.h>
> >  
> > 
> > -- 
> > 2.39.2
> >