netdev - Re: [PATCH net v2 1/3] net: ethernet: mtk_eth_soc: fix flow block refcounting logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f4fd578f-f9fb-6df7-2927-c652789ec236@nbd.name>
Date:   Thu, 30 Mar 2023 14:22:44 +0200
From:   Felix Fietkau <nbd@....name>
To:     Leon Romanovsky <leon@...nel.org>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net v2 1/3] net: ethernet: mtk_eth_soc: fix flow block
 refcounting logic

On 30.03.23 14:13, Leon Romanovsky wrote:
> On Thu, Mar 30, 2023 at 02:08:38PM +0200, Felix Fietkau wrote:
>> Since we call flow_block_cb_decref on FLOW_BLOCK_UNBIND, we also need to
>> call flow_block_cb_incref for a newly allocated cb.
>> Also fix the accidentally inverted refcount check on unbind.
>> 
>> Fixes: 502e84e2382d ("net: ethernet: mtk_eth_soc: add flow offloading support")
>> Reviewed-by: Simon Horman <simon.horman@...igine.com>
>> Signed-off-by: Felix Fietkau <nbd@....name>
>> ---
>>  drivers/net/ethernet/mediatek/mtk_ppe_offload.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> So what was changed between version 1 and 2?
> It is expected to send cover letter too for series with more than 2 patches.
I had already sent v2 without the net prefix, this was just a resend 
without any further code changes.
Unfortunately I forgot to copy the changelog as well. Here it is:
   v2: fix description, simplify refcounting change

Sorry about that.

- Felix